Menu button column HLD #2134
Merged
Menu button column HLD #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atmgrifter00, can you buddy this PR for me? |
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Outdated
Show resolved
Hide resolved
msmithNI
reviewed
May 24, 2024
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Show resolved
Hide resolved
…table-column-menu-button.md Co-authored-by: Jonathan Meyer <26874831+atmgrifter00@users.noreply.github.com>
atmgrifter00
approved these changes
May 30, 2024
fredvisser
reviewed
May 31, 2024
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Outdated
Show resolved
Hide resolved
fredvisser
reviewed
May 31, 2024
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
May 31, 2024
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Show resolved
Hide resolved
stefanc18
reviewed
Jun 3, 2024
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Jun 11, 2024
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-menu-button.md
Show resolved
Hide resolved
rajsite
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Create HLD for the menu button table column.
👩💻 Implementation
N/A
🧪 Testing
N/A
✅ Checklist